make convert_hn() public instead of internal #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This reverts 3466061 which fixed the bug that converting |
|
@AlexVonB - there is no We could rename What are your thoughts? |
chrispy-snps
force-pushed
the
chrispy/make-convert_hn-public
branch
from
8cda560 to
ee8c98f
Compare
|
@AlexVonB - I updated the pull request to use |
chrispy-snps
force-pushed
the
chrispy/make-convert_hn-public
branch
from
ee8c98f to
fb34e5b
Compare
Signed-off-by: chrispy <chrispy@synopsys.com>
chrispy-snps
force-pushed
the
chrispy/make-convert_hn-public
branch
from
fb34e5b to
960e2cd
Compare
|
Perfect solution! I pondered a bit on the initial problem but this is the best solution |
Wuhall
pushed a commit
to Wuhall/python-markdownify
that referenced
this pull request
May 21, 2025
Signed-off-by: chrispy <chrispy@synopsys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
convert_hn()public instead of internal, to allow for custom heading conversion functions.